feat(cors): Add CORS policy check and response to browsers. #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AOrazaev
commented
May 20, 2025
AOrazaev
commented
May 20, 2025
AOrazaev
commented
May 20, 2025
AOrazaev
commented
May 20, 2025
|
@microsoft-github-policy-service agree |
AOrazaev
force-pushed
the
orazaev/cors_support
branch
from
b21f59d to
770eae1
Compare
config.d.ts
Outdated
| /** | ||
| * Origins to allow by CORS policy. Can be regex. | ||
| */ | ||
| corsAllowOrigins?: RegExp[]; |
There was a problem hiding this comment.
This rather belongs to the 'server' section.
There was a problem hiding this comment.
Good suggestion. Moved to the server.
src/transport.ts
Outdated
| if (origin === undefined) | ||
| return false; | ||
|
|
||
| if (config.network.corsAllowOrigins.some(re => re.test(origin))) { |
There was a problem hiding this comment.
What is your use case? This exposes universal access to the host machine to the client, including full access to the fs.
There was a problem hiding this comment.
We have a browser based "agent prototype" which connects to the localhost playwright-mcp. By default browsers will not allow connection because of CORS policies. So for now user starts playwright-mcp on his machine, adds "agent url" to allowed origins and then connection can be made.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.