[emitter-framework] Render discriminated unions correctly #7369
+286
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All changed packages have been documented.
|
|
You can try these changes here
|
maorleger
requested review from
bterlson,
markcowl,
timotheeguerin,
witemple-msft,
chrisradek and
AlitzelMendez
as code owners
packages/emitter-framework/test/typescript/components/union-declaration.test.tsx
Show resolved
Hide resolved
|
|
||
| const [namespace] = program.resolveTypeReference("DemoService"); | ||
| const union = Array.from((namespace as Namespace).enums.values())[0]; | ||
| it("renders a discriminated union declaration with no envelope", async () => { |
There was a problem hiding this comment.
what does it looks like in thoses cases when you use a named model?
| }, | ||
| }); | ||
|
|
||
| return <TypeExpression type={model} />; |
There was a problem hiding this comment.
I think a better type might be to create a typescript intersection here for each variant.
type Pet = {kind: "a"} & Cat | {kind: "b"} & DogThere was a problem hiding this comment.
or at least if the model has a name
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the handling of discriminated unions in the
@typespec/emitter-frameworkpackage. It introduces new rendering logic for discriminated unions, updates existing components to support these changes, and improves test coverage to validate the new functionality.Enhancements to discriminated union rendering:
ObjectEnvelopeandNoneEnvelopefunctions inunion-expression.tsx. These handle different discriminator configurations and ensure proper rendering of union variants. [1] [2]Updates to existing components:
InterfaceBodycomponent ininterface-declaration.tsxto include a semicolon when rendering type members, ensuring consistency with TypeScript syntax. Found in passing and validated via the new testsImprovements to test coverage:
union-declaration.test.tsxusing the new testing patternsFixes #7174