WIP http: Rework HTTP analysis APIs to accept VisibilityFilter #8204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work-in-progress PR is an attempt to fix returnTypeVisibility/parameterVisibility by changing the HTTP library to use VisibilityFilter instances internally instead of
Visibility
flags. The public API is extended to accept VisibilityFilter everywhere that Visibility was required, and the API converts from Visibility to VisbilityFilter more eagerly.This (provisionally, for the purposes of being able to easily identify where the flags type is used -- we may or may not decide to go forward with this) deprecates
Visibility
and the old signature forgetVisibilitySuffix
in favor of APIs that consume VisibilityFilter instances directly.This hasn't quite fixed the issues with returnTypeVisibility but it's a step in the right direction.