-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added E2E execution plan tests with coverage #18929
Conversation
PR Changes
|
Are you planning to add these tests to the CI pipeline in a seperate PR? |
Yes, I'm adding it in later |
Using the example, I was able to access elements inside the webviews. I opened the connection dialog, found the webview iframe, located the profile name field, and filled it in with a dummy profile name. const connectionDialogFrame = vsCodePage
.frameLocator(".webview")
.frameLocator("[title='Connection Dialog (Preview)']");
if (connectionDialogFrame) {
const inputField = connectionDialogFrame.getByLabel("Profile Name");
await expect(inputField).toBeVisible({ timeout: 10000 });
const isInputFieldVisible = await inputField.isVisible();
if (isInputFieldVisible) {
await inputField.fill("Server Name");
}
} |
This looks great! |
I'll change the tests to this format! thanks for finding this |
@lewis-sanchez is merging for me because I still have the merge permissions issue |
Set up playwright infrastructure for collecting coverage on react webviews and testing react webviews. There's also a few really minor changes to some Execution Plan react components, which just make it easier to playwright test them.