Skip to content

Support Ruby 2.7/ 3.0 #64

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support Ruby 2.7/ 3.0 #64

wants to merge 3 commits into from

Conversation

apersaud
Copy link
Member

@apersaud apersaud commented May 4, 2021

  • Supports separation of positional and keyword arguments for Ruby 3.0
  • Replaces use of &Proc.new

@apersaud apersaud mentioned this pull request May 4, 2021
Open
apersaud and others added 2 commits May 3, 2021 18:05
@apersaud
[#62] Separate positional and keyword arguments for Ruby 3.0
54e2514
@hspindell @apersaud
Replaces deprecated Proc.new usage
5841de0 
“warning: Capturing the given block using Proc.new is deprecated; use `&block` instead”
@apersaud apersaud requested a review from hspindell May 4, 2021 01:05
hspindell
hspindell reviewed May 13, 2021
View reviewed changes
Copy link
Collaborator

@hspindell hspindell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the spec dependencies as well? (faraday in particular allow >=1)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hspindell hspindell hspindell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apersaud @hspindell