-
Notifications
You must be signed in to change notification settings - Fork 257
KAFKA-438: Create DeleteOneTombstoneBusinessKeyStrategy.java #175
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0e05b1f
KAFKA-438: Create DeleteOneTombstoneBusinessKeyStrategy.java
Calvinnix a657014
base DeleteOneTombstoneBusinessKeyStrategy on DeleteOneDefaultStrategy
Calvinnix 430ec0e
adjust tests
Calvinnix 9f379a3
throw exception if not configured as expected
Calvinnix c414274
fix lint
Calvinnix ce84329
clean up code
Calvinnix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
61 changes: 61 additions & 0 deletions
61
...mongodb/kafka/connect/sink/writemodel/strategy/DeleteOneTombstoneBusinessKeyStrategy.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| /* | ||
| * Copyright 2008-present MongoDB, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.mongodb.kafka.connect.sink.writemodel.strategy; | ||
|
|
||
| import static com.mongodb.kafka.connect.sink.writemodel.strategy.WriteModelHelper.flattenKeys; | ||
|
|
||
| import org.apache.kafka.connect.errors.ConnectException; | ||
| import org.apache.kafka.connect.errors.DataException; | ||
|
|
||
| import org.bson.BsonDocument; | ||
|
|
||
| import com.mongodb.client.model.DeleteOneModel; | ||
| import com.mongodb.client.model.WriteModel; | ||
|
|
||
| import com.mongodb.kafka.connect.sink.Configurable; | ||
| import com.mongodb.kafka.connect.sink.MongoSinkTopicConfig; | ||
| import com.mongodb.kafka.connect.sink.converter.SinkDocument; | ||
| import com.mongodb.kafka.connect.sink.processor.id.strategy.IdStrategy; | ||
| import com.mongodb.kafka.connect.sink.processor.id.strategy.PartialKeyStrategy; | ||
|
|
||
| public class DeleteOneTombstoneBusinessKeyStrategy implements WriteModelStrategy, Configurable { | ||
| private IdStrategy idStrategy; | ||
|
|
||
| @Override | ||
| public WriteModel<BsonDocument> createWriteModel(final SinkDocument document) { | ||
| document | ||
| .getKeyDoc() | ||
| .orElseThrow( | ||
| () -> | ||
| new DataException( | ||
| "Could not build the WriteModel,the key document was missing unexpectedly")); | ||
|
|
||
| if (!(idStrategy instanceof PartialKeyStrategy)) { | ||
| throw new ConnectException( | ||
| "DeleteOneTombstoneBusinessKeyStrategy expects PartialKeyStrategy to be defined"); | ||
| } | ||
|
|
||
| BsonDocument businessKey = idStrategy.generateId(document, null).asDocument(); | ||
| businessKey = flattenKeys(businessKey); | ||
| return new DeleteOneModel<>(businessKey); | ||
| } | ||
|
|
||
| @Override | ||
| public void configure(final MongoSinkTopicConfig configuration) { | ||
| idStrategy = configuration.getIdStrategy(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up opting to just create a new write model instead of updating DeleteOneBusinessKeyStrategy, the risk would be if we add the ability to start deleting on key values when tombstone events are sent, documents might start being deleted when they weren't in previous versions.