群组内一键添加好友 || One-click to add friends to the group #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for tailchat-nightly pending review.Visit the deploys page to approve it
|
github-actions
bot
changed the title
|
修改密码处添加密码验证规则 Add password verification rules |
moonrailgun
requested changes
Sep 1, 2024
| @@ -45,6 +45,10 @@ const schema = createMetaFormSchema({ | |||
| newPassword: metaFormFieldSchema | |||
| .string() | |||
| .min(6, t('密码不能低于6位')) | |||
| .matches(/[A-Z]/, '密码必须包含大写字母') | |||
There was a problem hiding this comment.
you should wrap with t which can include translation support
| @@ -84,6 +95,12 @@ export const GroupUserPopover: React.FC<{ | |||
| <div className="pt-2">{pluginUserExtraInfoEl}</div> | |||
|
|
|||
| <div className="text-right"> | |||
| <Tooltip title={t('添加好友')}> | |||
There was a problem hiding this comment.
i think its should also have a permission check like allowSendMessage because its should can be close if some group dont wanna allow user DM
| @@ -41,6 +43,15 @@ export const GroupUserPopover: React.FC<{ | |||
| navigate(`/main/personal/converse/${converse._id}`); | |||
| }, [navigate]); | |||
|
|
|||
| // 一键添加好友 | |||
| const [, handleAddFriend] = useAsyncRequest(async () => { | |||
| const { data } = await request.post('/api/friend/request/add', { | |||
There was a problem hiding this comment.
i think you should use addFriendRequest in client/shared/model/friend.ts
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
群组内一键添加好友
One-click to add friends to the group