refactor(deploy): improve types to avoid extraneous runtime check #7220
+8
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is messy, but by improving the typess and avoiding some reassignments we can let TS understand it better and avoid an extraneous runtime check.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By improving these types and avoiding some reassignments we can let TS understand it better and avoid an extraneous runtime check.
Reviewer: this isn't easy to explain, because this code is quite messy. I suggest carefully reading through the logic in the
mainversion before trying to grok my diff.Follow-up to https://github.com/netlify/cli/pull/7194/files#r2039642849