feat: beautify CLI update available notification and link to release notes #7237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
commented
Apr 24, 2025
| const { createMainCommand } = await import('../dist/commands/main.js') | ||
| const { logError } = await import('../dist/utils/command-helpers.js') | ||
| const { default: getPackageJson } = await import('../dist/utils/get-cli-package-json.js') | ||
| const { runProgram } = await import('../dist/utils/run-program.js') | ||
|
|
||
| const pkg = await getPackageJson() |
There was a problem hiding this comment.
unrelated, but I moved this into the try-catch since it's only for the update notification stuff that we want to degrade gracefully
ndhoule
approved these changes
Apr 25, 2025
serhalp
deleted the
serhalp/cpla-2681-timebox-make-the-cli-update-call-to-action-more-enticing
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This polishes the look and brand of the CLI update available notification and adds a link to release notes.
When looking at the screenshots below, keep in mind they just show my own terminal background and colour configuration. These can vary, but we do use libraries that automatically adapt to available color space, support for OSC 8 terminal links, etc.
Before
After