Improve AWS Batch spot reclamation error messages #6253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging canceled.
|
- Add clearer error messages when spot instances are reclaimed - Provide guidance on configuring maxSpotAttempts for automatic retries - Add logging for retry attempts and spot reclamation configuration - Include helpful link to AWS documentation on spot interruptions This addresses issues nextflow-io#5240 and nextflow-io#6225 by making spot reclamation failures more user-friendly and providing actionable guidance. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
ewels
force-pushed
the
fix-spot-reclamation-error-messages
branch
from
3f96788 to
12f7b22
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Experimentation - having a play with using Claude Code in the terminal to fix Nextflow issues. I haven't written or read this code. Feel free to bin it if it's junk (very likely).
Summary
maxSpotAttemptsfor automatic retriesChanges Made
isSpotReclamationError()method to detect spot reclamation failuresformatSpotReclamationError()method to provide user-friendly error messagescheckIfCompleted()to use improved messagesmaxSpotAttemptssettingFixes
Test Plan
maxSpotAttempts = 0(current default) to ensure guidance is shownmaxSpotAttempts > 0to verify retry configuration messages🤖 Generated with Claude Code