Skip to content

Add support for notifying a service #247

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

njdancer
Copy link

No description provided.

njdancer added 2 commits July 9, 2017 13:56
This is useful when deploying stacks as the container_name cannot be set at design time.
@k3a
Copy link

k3a commented Sep 22, 2019

It works great, thanks. I don't understand why this hasn't been merged already.

I would just add this at the beginning of task for iteration body:

			if task.Status.State != "running" {
				continue
			}

And maybe also say which container the signal could not be sent to:

			if err := g.Client.KillContainer(killOpts); err != nil {
-				log.Printf("Error sending signal to container: %s", err)
+				log.Printf("Error sending signal to container %s: %s", container, err)
			}

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants