Add source to logs in Debug Mode & Clean up function names #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-david3
reviewed
Jun 5, 2025
dhurley
reviewed
Jun 5, 2025
| @@ -398,6 +400,7 @@ func (oc *Collector) checkForNewReceivers(nginxConfigContext *model.NginxConfigC | |||
| nginxReceiverFound, reloadCollector := oc.updateExistingNginxPlusReceiver(nginxConfigContext) | |||
|
|
|||
| if !nginxReceiverFound && nginxConfigContext.PlusAPI.URL != "" { | |||
| slog.Debug("Adding new Nginx Plus receiver", "url", nginxConfigContext.PlusAPI.URL) | |||
There was a problem hiding this comment.
Suggested change
| slog.Debug("Adding new Nginx Plus receiver", "url", nginxConfigContext.PlusAPI.URL) | |
| slog.Debug("Adding new NGINX Plus receiver", "url", nginxConfigContext.PlusAPI.URL) |
| @@ -413,6 +416,7 @@ func (oc *Collector) checkForNewReceivers(nginxConfigContext *model.NginxConfigC | |||
|
|
|||
| reloadCollector = true | |||
| } else if nginxConfigContext.PlusAPI.URL == "" { | |||
| slog.Debug("Adding new Nginx Oss receiver", "url", nginxConfigContext.StubStatus.URL) | |||
There was a problem hiding this comment.
Suggested change
| slog.Debug("Adding new Nginx Oss receiver", "url", nginxConfigContext.StubStatus.URL) | |
| slog.Debug("Adding new NGINX OSS receiver", "url", nginxConfigContext.StubStatus.URL) |
| @@ -465,6 +469,8 @@ func (oc *Collector) updateExistingNginxPlusReceiver( | |||
| oc.config.Collector.Receivers.NginxPlusReceivers[index+1:]..., | |||
| ) | |||
| if nginxConfigContext.PlusAPI.URL != "" { | |||
| slog.Debug("Updating existing Nginx Plus receiver", "url", | |||
There was a problem hiding this comment.
Suggested change
| slog.Debug("Updating existing Nginx Plus receiver", "url", | |
| slog.Debug("Updating existing NGINX Plus receiver", "url", |
| @@ -496,6 +502,8 @@ func (oc *Collector) updateExistingNginxOSSReceiver( | |||
| oc.config.Collector.Receivers.NginxReceivers[index+1:]..., | |||
| ) | |||
| if nginxConfigContext.StubStatus.URL != "" { | |||
| slog.Debug("Updating existing Nginx Oss receiver", "url", | |||
There was a problem hiding this comment.
Suggested change
| slog.Debug("Updating existing Nginx Oss receiver", "url", | |
| slog.Debug("Updating existing NGINX OSS receiver", "url", |
john-david3
approved these changes
Jun 9, 2025
craigell
approved these changes
Jun 9, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)