Skip to content

Add pull policy to Minikube local tests #7759

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented May 7, 2025

Proposed changes

  • allow setting of pull policy for minikube tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner May 7, 2025 14:21
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels May 7, 2025
@AlexFenlon AlexFenlon moved this from Todo ☑ to In Review 👀 in NGINX Ingress Controller May 8, 2025
@AlexFenlon AlexFenlon self-assigned this May 8, 2025
pdabelf5
pdabelf5 previously approved these changes May 13, 2025
Signed-off-by: AlexFenlon <a.fenlon@f5.com>
Signed-off-by: AlexFenlon <a.fenlon@f5.com>
@AlexFenlon AlexFenlon changed the title Add labels to NAP pytest and add pull policy to Minikube local tests Add pull policy to Minikube local tests May 14, 2025
@github-actions github-actions bot removed the python Pull requests that update Python code label May 14, 2025
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.34%. Comparing base (f4ed950) to head (fa2bc11).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7759   +/-   ##
=======================================
  Coverage   52.34%   52.34%           
=======================================
  Files          89       89           
  Lines       21373    21373           
=======================================
  Hits        11188    11188           
  Misses       9719     9719           
  Partials      466      466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tests Pull requests that update tests
Projects
Status: In Review 👀
Development

Successfully merging this pull request may close these issues.

3 participants