Skip to content

feat(lib): allow to add custom storage #28

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

va-stefanek
Copy link

@va-stefanek va-stefanek commented May 26, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently we can only use localStorage as a persistence storage

Issue Number: #6

What is the new behavior?

We can use any persistence storage which extends proper interface

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@va-stefanek va-stefanek force-pushed the feature/custom-storage branch from 5e4efc4 to b7883b8 Compare May 26, 2021 17:28
@NetanelBasal
Copy link
Member

Thanks for the PR. Can you update the docs, please?

@va-stefanek va-stefanek force-pushed the feature/custom-storage branch from b7883b8 to 1e1fe55 Compare May 27, 2021 06:54
@va-stefanek
Copy link
Author

@NetanelBasal Done.

@AdmilsonCossa
Copy link

Any updates on this feature? This is very important!

@va-stefanek
Copy link
Author

@AdmilsonCossa I will try to complete this by the end of the week.

@hiepxanh
Copy link

@va-stefanek looking for your update sir :D

@va-stefanek va-stefanek force-pushed the feature/custom-storage branch from 1e1fe55 to 07dfcfe Compare November 17, 2021 21:19
@va-stefanek
Copy link
Author

va-stefanek commented Nov 17, 2021

@NetanelBasal let me know if we are still interested in that feature, whether we should remove FORMS_MANAGER_SESSION_STORAGE_PROVIDER. I have pushed new changes with using @ngneat/storage

Sorry everyone for the delay.

@hiepxanh
Copy link

ya I'm looking for this feature still waiting :D

@NetanelBasal
Copy link
Member

@va-stefanek sure

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants