-
-
Notifications
You must be signed in to change notification settings - Fork 260
test build time with xcp #788
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
Mic92
wants to merge
7
commits into
master
Choose a base branch
from
xcp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small improvement for integration test: 3:18 -> 2:48 |
The difference is not big enough, to justify merging this now. |
The flag was added. Waiting for an xcp release. |
@mergify rebase |
☑️ Nothing to do
|
Notes:
Once upgrade has landed in nixpkgs, this PR is unblocked. |
xcp 0.22.0 was released, nixpkgs PR opened: NixOS/nixpkgs#355776 |
34dd137
to
a6c345d
Compare
iFreilicht
requested changes
Dec 5, 2024
62a07e1
to
d7ef4a8
Compare
for images we don't want nix to scan our image for refernnces
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on NixOS/nixpkgs#362081