-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[WIP] #49
base: main
Are you sure you want to change the base?
[WIP] #49
Conversation
We've used |
Nonetheless, I like the idea that we build multiple target formats. (btw do we really need the CJS target? I understand that the UMD one is for single-file distribution, and the ESM one for pakage managers. CJS just seems redundant 🤔 |
Actually I once thought so too (but nevertheless merged that PR. I forgot the reason why). Let’s remove it |
I would like to try @microsoft/api-extractor, but I don’t think I’ll have the time to dig into it anytime soon. Help me take a look into it if you’ve got the time (unless you don’t think doubling the file size (before gzip) is a problem) 😄 |
@syimyuzya I don’t think the entire type definition is currently in a usable state: P.S. Be careful not to make the same mistake I made with the library mentioned above, which is a problem Masquerading as ESM/CJS: |
I just found that the ESM build in this configuration is also bundled into a single file 🤔
|
Bundle type declaration to avoid exposing internal types and enforce encapsulation
TODOs
index.d.ts
into actual code pointsAlternatively, use
rollup-plugin-dts