Skip to content

Conversation

arkandias
Copy link

The purpose of this PR is:

Remove dependency node-domexception which is deprecated in favor of Node.js native DOMException (available since Node.js 17).

This is what had to change:

  • Bump minimum Node.js version from >=16.7 to >=17
  • Remove node-domexception from dependencies

This is what reviewers should know:

  • All existing tests pass except one unrelated Float16Array test failure

  • I prefixed the PR-title with docs: , fix(area): , feat(area): or breaking(area):
  • I updated the README.md
  • I Added unit test(s)

@harshsoni-harsh
Copy link

will this PR merge?

@arkandias
Copy link
Author

@YasharF If this looks good to you, could you approve it?

@arkandias
Copy link
Author

@jayvdb @YasharF @jimmywarting Just a friendly bump in case any of you has the time to review the updated PR

@YasharF
Copy link

YasharF commented Aug 31, 2025

I am not a maintainer. I don't think if node-fetch and related projects are being maintained anymore. You may want to consider switching to an alternate solution such as nodejs's builtin fetch api.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All versions of node-domexception have been deprecated
4 participants