Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: run test suite on windows #3479

Draft
wants to merge 10 commits into
base: v3
Choose a base branch
from
Draft

ci: run test suite on windows #3479

wants to merge 10 commits into from

Conversation

sandros94
Copy link
Member

@sandros94 sandros94 commented Mar 7, 2025

πŸ”— Linked issue

Related: nuxt/ecosystem-ci#15

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This both fixes the development of Nuxt UI on windows as well as run CI tests on windows-latest too

TODO

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sandros94 sandros94 self-assigned this Mar 7, 2025
@sandros94 sandros94 added the v3 #1289 label Mar 7, 2025
Copy link

pkg-pr-new bot commented Mar 7, 2025

npm i https://pkg.pr.new/@nuxt/ui@3479

commit: faca217

Copy link
Contributor

nuxthub-admin bot commented Mar 7, 2025

βœ… Deployed ui3

Deployed ui3 faca217 to preview

πŸ”— fix-windows-dev.ui-6q2.pages.dev
πŸ“Œ 7799606e.ui-6q2.pages.dev
πŸ“±
View QR Code QR code linking to deployment URL.

πŸ“‹ View deployment logs

This reverts commit 9e24c40.
@sandros94
Copy link
Member Author

@danielroe upgrading to @nuxt/module-builder@1.0.0-alpha.1 did indeed solve the issue (alongside an upstream fix from nuxt-component-meta).

unbuild v3 works great but this also introduced mkdist v2, which atm doesn't support typescript in templates (mkdist#281). Is it safe to pin mkdist to v1.6 while using unbuild v3 and moudle-builder v1 alpha?

@sandros94 sandros94 marked this pull request as ready for review March 31, 2025 19:09
@sandros94 sandros94 marked this pull request as draft March 31, 2025 19:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant