Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add setTimeout to ensure element receives focus #3571

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
+4 −2
Open

fix: add setTimeout to ensure element receives focus #3571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77f63b6
fix: add setTimeout to ensure element receives focus
kalicki2k Mar 14, 2025
1455c29
Merge branch 'v3' into patch-1
kalicki2k Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/app/components/content/examples/form/FormExampleOnError.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ async function onSubmit(event: FormSubmitEvent<typeof state>) {
async function onError(event: FormErrorEvent) {
if (event?.errors?.[0]?.id) {
const element = document.getElementById(event.errors[0].id)
element?.focus()
element?.scrollIntoView({ behavior: 'smooth', block: 'center' })
setTimeout(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit hacky, can we use nextTick instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit hacky, can we use nextTick instead?

indeed, as the main thread could be put on hold by the browser/OS while setTimeout run just fine in another thread taking us nowhere 😕

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried nextTrick, but it does not work. That's why I used setTimeout. @romhml

element?.focus()
element?.scrollIntoView({ behavior: 'smooth', block: 'center' })
}, 0)
}
}
</script>
Expand Down