fix(ui): allow built-in completions in orgmode.ui.input #903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow
ui.input
to take not only functions for custom completion, but also strings for buil-in completion.The org-attach feature uses both the
dir
built-in completion (to choose a directory to attach) and thebuffer
built-in completion (to choose a buffer whose contents are to be attached).Related Issues
Extracted from #878
Changes
orgmode.ui.input.open()
to allow string-type completion argumentstype(completion)
being a string.Checklist
I confirm that I have:
feat: add new feature
,fix: correct bug
,docs: update documentation
).make test
.