fix(statistics cookie): count only TODO headlines #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the todo statistics cookie was counting all child headlines in its calculation, regardless of whether they had TODO keywords. This fix modifies the `update_todo_cookie` function to: 1. Filter child headlines to only those with valid TODO keywords 2. Calculate the ratio of DONE tasks to total tasks with TODO keywords 3. Update the cookie with the correct statistics This ensures consistency with Org Mode's behavior where non-task headlines are excluded from statistics calculations.
kristijanhusak
approved these changes
Mar 17, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kristijanhusak Sorry to open this again, I made a mistake when creating the original PR from Octo.nvim: The base branch selected was the master branch from my forked repository, not the original upstream repository. So the PR merge went into the wrong branch.
Old PR message
Previously, the todo statistics cookie was counting all child headlines in its calculation, regardless of whether they had TODO keywords. This fix modifies the
update_todo_cookiefunction to:This ensures consistency with Org Mode's behavior where non-task headlines are excluded from statistics calculations.
Summary
This PR adds..
Related Issues
Related #
Closes #
Changes
Checklist
I confirm that I have:
Conventional Commits
specification (e.g.,
feat: add new feature,fix: correct bug,docs: update documentation).make test.