Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix failing build #1259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mildsunrise
Copy link

Description

current code in master fails to build because Json.cpp uses std::filesystem without including <filesystem>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.

current code in master fails to build because `Json.cpp`
uses `std::filesystem` without including `<filesystem>`
@tt2468
Copy link
Member

tt2468 commented Feb 15, 2025

On what environment is build failing for you?

@mildsunrise
Copy link
Author

it's been half a year. I don't know the exact environment that this failure happened on, but this mistake seemed trivial enough that i didn't debug back then. If it helps I was using Arch Linux, and building obs-studio from latest master at that time. I'll try to reproduce...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants