Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

utils: Add multi video and frame rate divisor support to GetOutputDuration #1274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

exeldro
Copy link
Contributor

@exeldro exeldro commented Dec 13, 2024

Description

Add multi video and frame rate divisor support to Utils::Obs::NumberHelper::GetOutputDuration

Motivation and Context

Fixes #1273

How Has This Been Tested?

With outputs with multiple video tracks of which some have frame rate divisors
Tested OS(s): Windows 11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

@tt2468
Copy link
Member

tt2468 commented Feb 15, 2025

The correct prefix for this commit would be utils:, rather than base.

@exeldro exeldro changed the title base: Add multi video and frame rate divisor support to GetOutputDuration utils: Add multi video and frame rate divisor support to GetOutputDuration Feb 25, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: output duration is wrong for TEB
2 participants