Fixes Tests

[ismaail]

I managed to fix all failing tests (see Github Actions)

but I had to skip 2 tests and disable webpage in routes as it need to be done in a different way.

[oitcode]

@ismaail Thanks for contributing once again.

Please give me some time to review the changes. Will update you soon.

[ismaail]

@oitcode no worries, take your time.

[oitcode]

@ismaail Hey, sorry for late response, as I was busy with other schedule.

All the changes look fine, however it seems the webpage routes in the routes/web.php file have been changed. WIthout those routes webpages added from the CMS module will not work correctly. So how to make those webpages work with those changes in routes/web.php file. I got confused. Any suggestions?

[ismaail]

@oitcode instead of creating a route for every webpage in routes/web.php,
my plan is to change this route to something like

Route::get('webpage/{permalink}', 'WebsiteController@webpage')->name('website-webpage');

and handle finding the webpage by permalink in the WebsiteController@webpage,
this way the application don't have to create the webpages routes in routes/web.php every time a webpage is added or deleted.

[oitcode]

@ismaail

Sorry again for delay in response.

I was thinking of a way to implement the webpages as

Route::get('/{permalink}', 'WebsiteController@webpage')->name('website-webpage');

because

Route::get('webpage/{permalink}', 'WebsiteController@webpage')->name('website-webpage');

would always have a /webpage/ part in the url for every webpage which is not ideal.

But, as of now I have not clearly figured out how to implement this.

Will update you once I am able to think of something. Your thoughts on this matter?

Also sorry as this PR has already been 3 weeks and am not able to merge it yet. Hope you understand. Thanks.

[ismaail]

I don't think I can add anything new, feel free to update this PR or close it.

Thanks.