Remove unnecessary conversions #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarakby
requested review from
devbugging,
turbolent,
janezpodhostnik,
bluesign and
chasefleming
as code owners
tarakby
changed the title
turbolent
approved these changes
Jan 17, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary conversions from/to
onflow/flow-go/cryptoandonflow/flow-go-sdk/cryptotypes. The types are defined to be equal and there is no need for conversions.The conversion is causing issues in the incremental work (incremental by repo) of deprecating
onflow/flow-go/crypto.