Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update cadence version #552

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Update cadence version #552

merged 3 commits into from
Jan 26, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Jan 22, 2024 •
edited
Loading

Description

Update to the cadence version which includes the dependency fix: onflow/cadence#3027

For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@SupunS SupunS added Improvement Technical work without new features, refactoring, improving tests Cadence 1.0 labels Jan 22, 2024
@SupunS SupunS self-assigned this Jan 22, 2024
@SupunS SupunS force-pushed the supun/update-deps branch from 6dcde21 to 5115cdb Compare January 25, 2024 16:14
@SupunS SupunS force-pushed the supun/update-deps branch from 5115cdb to f1971b5 Compare January 25, 2024 16:25
@turbolent turbolent mentioned this pull request Jan 25, 2024
Merged
@tarakby
Copy link
Contributor

tarakby commented Jan 26, 2024

@SupunS are the contracts (core-contrcats, nft, ft) currently being updated ? Are there PRs I should track about the updates? This is to unblock an emulator PR similar to yours :)

@SupunS
Copy link
Member Author

SupunS commented Jan 26, 2024

@tarakby Josh is working on updating the contracts. There is a PR to update flow-go with the latest changes: onflow/flow-go#5301. Not sure if that will fix this issue for sure, but once that PR got merged, I will update this PR and see.

@SupunS SupunS marked this pull request as ready for review January 26, 2024 17:02
@SupunS SupunS requested a review from dsainati1 January 26, 2024 17:03
dsainati1
dsainati1 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@dsainati1 dsainati1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This should unblock #553

@SupunS SupunS mentioned this pull request Jan 26, 2024
Closed
6 tasks
turbolent
turbolent approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@turbolent turbolent merged commit 92e2ffc into master Jan 26, 2024
3 checks passed
@turbolent turbolent deleted the supun/update-deps branch January 26, 2024 19:18
@tarakby
Copy link
Contributor

tarakby commented Jan 26, 2024

Nice work 👏🏼

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@dsainati1 dsainati1 dsainati1 approved these changes

@devbugging devbugging Awaiting requested review from devbugging

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@bluesign bluesign Awaiting requested review from bluesign bluesign is a code owner

@chasefleming chasefleming Awaiting requested review from chasefleming chasefleming is a code owner

Assignees

@SupunS SupunS

Labels
Cadence 1.0 Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SupunS @tarakby @turbolent @dsainati1