Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support state migration for emulator state #557

Merged
merged 12 commits into from
Feb 13, 2024
Merged

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Feb 2, 2024

Closes onflow/cadence#3063


For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@SupunS SupunS changed the title Supun/state migration Support state migration for emulator state Feb 2, 2024
@SupunS SupunS force-pushed the supun/state-migration branch 2 times, most recently from 9d5ee8a to 784061c Compare February 2, 2024 00:45
@SupunS SupunS force-pushed the supun/state-migration branch 2 times, most recently from ac98409 to 7590ef8 Compare February 2, 2024 01:04
@SupunS SupunS force-pushed the supun/state-migration branch from 7590ef8 to be38477 Compare February 2, 2024 01:05
@SupunS SupunS self-assigned this Feb 2, 2024
@SupunS SupunS added the Feature A new user feature or a new package API label Feb 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (ce8332d) 53.01% compared to head (4bf481b) 53.35%.

Files Patch % Lines
storage/migration/cadence_values_migration.go 54.71% 17 Missing and 7 partials ⚠️
storage/migration/utils.go 65.51% 17 Missing and 3 partials ⚠️
storage/migration/system_contracts_migration.go 67.56% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   53.01%   53.35%   +0.33%     
==========================================
  Files          29       32       +3     
  Lines        3876     4024     +148     
==========================================
+ Hits         2055     2147      +92     
- Misses       1668     1710      +42     
- Partials      153      167      +14     
Flag Coverage Δ
unittests 53.35% <62.16%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent marked this pull request as ready for review February 13, 2024 00:18
@turbolent
Copy link
Member

@SupunS I know you can't review your own PR, but could you please review the changes I made to the PR?

@j1010001 j1010001 modified the milestones: OKR_C2-KR1-C1.0-Upgrade_testing, OKR_C2-KR2-C1.0-Preview_launch Feb 13, 2024
Copy link
Member Author

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turbolent looks good! Nice cleanup by re-using/refactoring the pipeline at flow-go side!

@turbolent turbolent merged commit 6a8a710 into master Feb 13, 2024
3 checks passed
@turbolent turbolent deleted the supun/state-migration branch February 13, 2024 15:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Feature A new user feature or a new package API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable state migration on emulator
5 participants