Isotopic relaxation timescales comparison #1494
Conversation
slayoo
changed the title
PySDM/physics/isotope_kinetic_fractionation_factors/merlivat_and_jouzel_1979.py
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,2 @@ | |||
| from PySDM.impl.null_physics_class import Null | |||
| from .merlivat_and_jouzel_1979 import MerlivatAndJouzel1979 | |||
There was a problem hiding this comment.
worth including the following existing snippet in this physics submodule:
PySDM/examples/PySDM_examples/Pierchala_et_al_2022/fig_4.ipynb
Lines 80 to 82 in 2918dda
There was a problem hiding this comment.
That's true. I have a problem with understanding this formula. Same is in Horita et al 2008, but in Gat 2001 is different (in Gat is also mentioned in Pierchała as reference to this formula)
Difference is that here it is formula for eps_diff
There was a problem hiding this comment.
that is the whole point of Formulae class - to offer different variants of these formulae to the users, let's implement both Gat... and Horita...
| @@ -0,0 +1,15 @@ | |||
| """ | |||
| kinetic fractionation factor and epsilon kinetic | |||
There was a problem hiding this comment.
OK to mention that it is used in Pierchala et al., but class would best be named with the label of the paper it was introduced in
| return 1 - eps_kinetic | ||
|
|
||
| @staticmethod | ||
| def eps_kinetic(*, theta, n, eps_diff, relative_humidity): |
There was a problem hiding this comment.
let's then remove it from the Pierchala notebook and use formulae.isotope_kinetic_fractionation_factors.eps_kinetic there
|
|
||
| class JouzelAndMerlivat1984: # pylint: disable=too-few-public-methods | ||
| @staticmethod | ||
| def alpha_kinetic(alpha_equilibrium, relative_humidity, D_heavy2D_light): |
There was a problem hiding this comment.
D might look like Deuterium - perhaps better to name it heavy_to_light_diffusivity_ratio?
No description provided.