-
Notifications
You must be signed in to change notification settings - Fork 901
Fix Singletons and Singleton Spawn #10688
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
* Fixes open-mpi#10590 * Singletons will not have a PMIx value for `PMIX_LOCAL_PEERS` so make that optional instead of required. * `&` is being confused as an application argument in `prte` instead of the background character * Replace with `--daemonize` which is probably better anyway Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@awlauria We will need to sync the prrte submodule pointer to pick up openpmix/prrte#1443 |
FWIW: I have fixed the What a tangled web we weave! |
@jjhursey When singletons are fully fixed, please merge open-mpi/ompi-scripts#62 so that singleton tests are added to the OMPI Jenkins CI. |
Hold this PR for combined testing. I'm trying to align the 3 repos to get a current view of the state of this work. I'm testing with Open MPI
With these changes it seems the things are failing again :( I'm investigating. |
Tested with Open MPI
So something must be missing from the OpenPMIx and/or PRRTE release branches. For Open MPI, since it uses the |
FYI: I pushed my set of tests open-mpi/ompi-tests-public#20 |
So it looks like an OpenPMIx issue - probably a missing commit from Here is the error message: tests are here
|
Ok we resolved the issue with OpenPMIx Once Open MPI
Once verified then we will PR these back to Open MPI v5.x |
PMIX_LOCAL_PEERS
so make that optional instead of required.
&
is being confused as an application argument inprte
instead of the background character
--daemonize
which is probably better anyway