feat: report migrate to cmp #2367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kapmaurya Please note that PR should be made to the kmp-impl branch, also don't forget to add Jira ticket number in the PR description. |
biplab1
reviewed
May 6, 2025
gradle/libs.versions.toml
Outdated
Comment on lines
547
to
548
| material3-android = { group = "androidx.compose.material3", name = "material3-android", version.ref = "material3AndroidVersion" } | ||
| androidx-ui-android = { group = "androidx.compose.ui", name = "ui-android", version.ref = "uiAndroid" } |
There was a problem hiding this comment.
Here also, you can remove these lines since these libraries already present in libs.versions.toml
niyajali
requested changes
May 6, 2025
There was a problem hiding this comment.
@kapmaurya Resolve these requested changes and let us know we'll proceed with merge.
feature/report/src/commonMain/kotlin/com/mifos/feature/report/report/ReportScreen.kt
Outdated
Show resolved
Hide resolved
feature/report/src/commonMain/kotlin/com/mifos/feature/report/runReport/RunReportScreen.kt
Outdated
Show resolved
Hide resolved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - (https://mifosforge.jira.com/browse/MIFOSAC-426)
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.