Skip to content

Unify notifications #1161

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Unify notifications #1161

wants to merge 4 commits into from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Mar 18, 2025

We had two different styles for notifications. This patch unifies those styles into one, mainly keeping the style that was used in most places anyway.

Also extracts a Notification component that allows other components to render a static object that looks like a notification without having to jump through the whole notification mechanism.

Also fixes #1151.

Before:
Bildschirmfoto vom 2025-03-18 15-46-40

After:
Bildschirmfoto vom 2025-03-18 15-46-11

How to test this

Can be tested as usual.

@Arnei
Unify notifications
beb277d 
We had  two different styles for notifications. This patch unifies
those styles into one, mainly keeping the style that was used in most
places anyway.

Also extracts a Notification component that allows other
components to render a static object that looks like a notification
without having to jump through the whole notification mechanism.

Also fixes opencast#1151.
@Arnei Arnei added the type:visual-clarity Improves UI readability label Mar 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1161

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1161

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025 •
edited
Loading

This pull request is deployed at test.admin-interface.opencast.org/1161/2025-03-20_13-49-55/ .
It might take a few minutes for it to become available.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@NadiaUoM NadiaUoM NadiaUoM approved these changes

Assignees
No one assigned
Labels
priority:medium type:visual-clarity Improves UI readability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display "The user is not manageable" on roles tab
2 participants
@Arnei @NadiaUoM