Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consistent list annotation #959

Open
wants to merge 8 commits into
base: devel
Choose a base branch
from

Conversation

Hemant27031999
Copy link
Contributor

This PR is solving issue #736 and #706. A new function _fix_annotation() has been added which fixes the incorrect annotation format.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2020

Codecov Report

Merging #959 into devel will decrease coverage by 0.17%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #959      +/-   ##
==========================================
- Coverage   84.63%   84.45%   -0.18%     
==========================================
  Files          50       50              
  Lines        4438     4459      +21     
  Branches      998     1006       +8     
==========================================
+ Hits         3756     3766      +10     
- Misses        441      449       +8     
- Partials      241      244       +3     
Impacted Files Coverage Δ
cobra/io/dict.py 87.50% <83.33%> (-0.97%) ⬇️
cobra/io/sbml.py 79.97% <100.00%> (-0.08%) ⬇️
cobra/core/object.py 94.28% <0.00%> (-5.72%) ⬇️
cobra/sampling/hr_sampler.py 83.42% <0.00%> (-2.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d362f51...351d5c3. Read the comment docs.

@Midnighter
Copy link
Member

Hey @Hemant27031999, this is good work but unfortunately, I don't think we can merge it without a change to the JSON schema. As you can read in #967, I would love to refactor this functionality into a separate package. And even if we don't do that, I think the JSON schema should be generated from pydantic models rather than crafted by hand. So I'm afraid, I can't merge this PR at this point as it is blocked.

@cdiener cdiener added the stale The issue or pull request lacks activity. label Sep 1, 2021
@cdiener cdiener removed the blocked label Jan 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
stale The issue or pull request lacks activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants