-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Consistent list annotation #959
base: devel
Are you sure you want to change the base?
Consistent list annotation #959
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #959 +/- ##
==========================================
- Coverage 84.63% 84.45% -0.18%
==========================================
Files 50 50
Lines 4438 4459 +21
Branches 998 1006 +8
==========================================
+ Hits 3756 3766 +10
- Misses 441 449 +8
- Partials 241 244 +3
Continue to review full report at Codecov.
|
Hey @Hemant27031999, this is good work but unfortunately, I don't think we can merge it without a change to the JSON schema. As you can read in #967, I would love to refactor this functionality into a separate package. And even if we don't do that, I think the JSON schema should be generated from pydantic models rather than crafted by hand. So I'm afraid, I can't merge this PR at this point as it is blocked. |
This PR is solving issue #736 and #706. A new function
_fix_annotation()
has been added which fixes the incorrect annotation format.