Add support for API Ingress #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheisFerre
reviewed
Feb 27, 2025
There was a problem hiding this comment.
I support this. Would be a nice addition to the helm chart! I did encounter an issue with the Ingress name though, it has to follow the kubernetes naming convention.
I also suggest that we add the option to change the pathType as there can be use cases where this will be relevant (i.e. Oauth2 Proxy in front of API)
Co-authored-by: Theis Ferré Hjortkjær <theisferre@gmail.com> Signed-off-by: Joseph Teddick <43552317+josephteddick@users.noreply.github.com>
|
@TheisFerre Thanks for reviewing, great suggestions! Just made the changes, let me know if there is anything else. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to allow users to give external access to the API by allowing for configuration of an Ingress.
Fix for issue: #254