Skip to content

8357056: RISC-V: Asm fixes - load/store width #25253

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robehn
Copy link
Contributor

@robehn robehn commented May 15, 2025

Hi, please consider.

While working on #25252, I notice:

  • Major op code was just repeat
  • Width coded in binary
  • Stores have mixed up rs1 and rs2
  • Bonus, fsd used a macro for no reason

I think this improves readability.

Tested tier1

Thanks, Robbin


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357056: RISC-V: Asm fixes - load/store width (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25253/head:pull/25253
$ git checkout pull/25253

Update a local copy of the PR:
$ git checkout pull/25253
$ git pull https://git.openjdk.org/jdk.git pull/25253/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25253

View PR using the GUI difftool:
$ git pr show -t 25253

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25253.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2025

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 15, 2025

@robehn The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 15, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant