Skip to content

CSAPI Android compatibility #286

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MichaelElmore1
Copy link

A couple of changes to make ConSysApiClient usable on Android devices:

  • In ConSysApiClient, switch from using HttpClient to HttpURLConnection. HttpClient doesn't exist in Android Java, but HttpURLConnection works for both.
  • In XMLImplFinder, return a null DOMImplementation in case of an error. Accessing DOMImplementationRegistry in Android throws a missing class exception, and a fallback already exists within the XMLDocument.java code. This change allows the fallback to be used instead of throwing an error.

Copy link
Member

@alexrobin alexrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not completely replacing the existing code based on the more modern Java HttpClient with the HttpURLConnection approach.

We should instead provide two separate implementations of these methods and automatically select depending on the platform.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants