[JDK-8345826] Replace +EnableJVMCI with --add-modules=jdk.internal.vm.ci. #11212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
ds/JDK-8345826
branch
7 times, most recently
from
38d43e2 to
a6af92c
Compare
Closed
3 tasks
graalvmbot
force-pushed
the
ds/JDK-8345826
branch
from
881674a to
59dfaf1
Compare
graalvmbot
force-pushed
the
ds/JDK-8345826
branch
from
be2fa03 to
0efa9f6
Compare
graalvmbot
force-pushed
the
ds/JDK-8345826
branch
from
0efa9f6 to
7c8fe14
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts to JDK-8345826.
In general, this PR replaces
-XX:+EnableJVMCIwith--add-modules=jdk.internal.vm.ci. As stated in openjdk/jdk#25240,--add-modules=jdk.internal.vm.ciwill (also) setEnableJVMCItotrue. The primary motivation for the JDK change is so that libgraal benefits from (and is tested against) Leyden-related CDS optimizations.This PR will need to target
galahadbefore merging.