Skip to content

refactor: always run build service check if repo is found #1088

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

behnazh-w
Copy link
Member

Summary

This PR ensures that the build_service_check is always executed when a repository is found, regardless of whether the build_as_code_check detects an automatic deployment. This is especially important for ecosystems like Python, where the build and deployment steps are often separated and may use different tools or workflows. By always running the check, we avoid missing critical build data needed for rebuilding packages.

Description of changes

Previously, if the build_as_code_check identified an automatic deployment, the build_service_check could be skipped. However, for build from source, it is important to collect all build commands. Skipping the build_service_check in such cases omits valuable information about the build process.

This change ensures that:

  • build_service_check runs whenever a repository is detected.
  • Build commands are consistently collected and reported, even if an automatic deployment is found.

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w behnazh-w requested a review from tromai as a code owner May 20, 2025 06:54
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 20, 2025
@behnazh-w behnazh-w marked this pull request as draft May 21, 2025 00:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant