Supporting connection using wallet #93
Open
+133
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
| throw (ConnectionException) e; | ||
| if (e instanceof ConnectionException) { // from Admin | ||
| Throwable t = e.getCause(); | ||
| if(t instanceof ConnectException) { |
There was a problem hiding this comment.
Can getCause returns null ?
What if t is not ConnectException ? Is it possible?
There was a problem hiding this comment.
->As of our current code getCause will always return something, but in case of null, that condition will return false, no error will be thrown.
-> Yes cause can be of Connect exception or any other regular SQLException.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to support Wallet use with okafka.