fix the range of keep data generation #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for making the PR.
|
mikecaat
reviewed
Feb 25, 2022
| @@ -165,32 +165,54 @@ echo '' | |||
| echo '###### COMMAND OPTION TEST-0017 ######' | |||
| echo '###### invalid value in pg_rman.ini ######' | |||
| init_catalog | |||
| echo "SMOOTH_CHECKPOINT=FOO" >> ${BACKUP_PATH}/pg_rman.ini | |||
There was a problem hiding this comment.
I think it's better not to change this line and change line 190 because the number of diff became minimum.
|
In the first place, I got not to be confidence that we must check if the values are zero because the users may want to remove the backup files. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set keep_data_generations = 0, the backup you got will be deleted immediately,
I think the setting like keep_data_generations = 0 is meaningless.
So, In this PR, the minimum value of the setting range of keep_data_generations has been changed to 1.
In addition, keep_srvlog_days, keep_srvlog_files have been modified in the same way.