fix tls Email settings #1197
Open
fix tls Email settings #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 18, 2024 17:23
This reverts commit 3b3013e.
|
Hey! Will anyone review this PR? Do I have to assign it to someone? |
|
This has been up for a year! Is anyone looking at this? |
Apologies this has taken so long, we're now looking into it. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
OVERLEAF_EMAIL_SMTP_TLS_REJECT_UNAUTHis used to setsettings.email.parameters.tls.rejectUnauthorizedinsettings.jswhich allows for using self-signed certificates when connecting to smtp email servers. However, thetlsparameter is never read out when instantiating the mailer client. This PR fixes this issue.Related issues / Pull Requests
fixes issue #1195
Contributor Agreement