Skip to content

Improved Auth Spec & challenge endpoint #1276

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 16 commits into
base: alpha
Choose a base branch
from

Conversation

Moumouls
Copy link
Member

@Moumouls Moumouls commented Dec 11, 2020

Need: #1275

SDK Login update for: https://github.com/parse-community/parse-server

Note: On OSX can test integration with 3.6, and tests fails in mongo 4.0 due to invalid field name "length"

If CI pass then we have detected a regression between mongo 3.6 and 4.0 for field name length on objects

  • Challenge mehod

# Conflicts:
#	integration/test/ParseLocalDatastoreTest.js
#	integration/test/ParseUserTest.js
#	package-lock.json
#	src/ParseUser.js
#	src/__tests__/ParseUser-test.js
# Conflicts:
#	src/__tests__/ParseUser-test.js
@ghost
Copy link

ghost commented Dec 11, 2020

Warnings
⚠️ Please add a changelog entry for your changes.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1276 (c787972) into master (4a75d97) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c787972 differs from pull request most recent head a31beb6. Consider uploading reports for the commit a31beb6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1276   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          60       60           
  Lines        5847     5869   +22     
  Branches     1311     1320    +9     
=======================================
+ Hits         5844     5866   +22     
  Misses          3        3           
Impacted Files Coverage Δ
src/ParseUser.js 99.59% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a75d97...a31beb6. Read the comment docs.

@Moumouls
Copy link
Member Author

Issue reported for Mongo 4.X and field name length: #1277

@Moumouls Moumouls marked this pull request as draft December 11, 2020 15:02
# Conflicts:
#	integration/test/ParseQueryTest.js
#	package-lock.json
#	package.json
#	src/ParseUser.js
#	src/__tests__/ParseUser-test.js
@Moumouls Moumouls changed the title NEED PRETTIER: Login auth data Login auth data Dec 14, 2020
@Moumouls Moumouls changed the title Login auth data Wait Parse Server: Login auth data Dec 15, 2020
@Moumouls Moumouls marked this pull request as ready for review December 15, 2020 11:33
@Moumouls
Copy link
Member Author

@dplewis if you have an idea on the failing integration test, npm run integration is okay on my side, may be a Github CI cache issue ?

@Moumouls Moumouls changed the title Wait Parse Server: Login auth data Improved Auth Spec & challenge endpoint Jan 18, 2021
@dplewis
Copy link
Member

dplewis commented Jan 18, 2021

@Moumouls Can you update from master?

# Conflicts:
#	jasmine.json
#	package-lock.json
@Moumouls
Copy link
Member Author

Moumouls commented Apr 9, 2021

@dplewis if you have some suggestion about the failing test ? 🙂

@dplewis
Copy link
Member

dplewis commented Apr 9, 2021

Can you update from master again? The new release removes the flaky tests.

@Moumouls
Copy link
Member Author

Moumouls commented Apr 9, 2021

Done @dplewis

@dblythy
Copy link
Member

dblythy commented Jan 4, 2023

@Moumouls how is this coming along? Would be good to have implemented for Parse Server 6

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants