-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
ci: Mongodb-runner usage and default version to 6.0.2 #9383
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: alpha
Are you sure you want to change the base?
ci: Mongodb-runner usage and default version to 6.0.2 #9383
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9383 +/- ##
=======================================
Coverage 93.49% 93.49%
=======================================
Files 186 186
Lines 14810 14810
=======================================
Hits 13846 13846
Misses 964 964 ☔ View full report in Codecov by Sentry. |
This PR should fix the issue of the mongodb runner not terminating all running instances? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try to run the command npx mongodb-runner stop --all --runnerDir ./_mongodb_runner
on linux and get:
[Error: ENOENT: no such file or directory, opendir './_mongodb_runner'] {
errno: -2,
code: 'ENOENT',
syscall: 'opendir',
path: './_mongodb_runner'
}
Node.js v18.18.2
Which is correct, the dir doesn't exist. I suppose something is missing in this PR? Doesn't starting the runner also require to specify the output dir for the runners?
Pull Request
Issue
Closes: none
Approach
Mongodb runner use a global folder by default, it could conflict with old failed instances or other running instances non related to parse-server development.
Now using a dedicated folder during contributing phase, so it's easier to clean the folder in case of unexpected failure.
Also updating default version to 6.0.2, because 6.X is compatible with Windows/Mac Intel/Mac ARM.
5.X don't start on Mac ARM so it always need a manual adjustment to contribute to parse.
5.X is now quite old also.
Tasks