chore(HelperText): updated a11y docs for SR text #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Venefilyn
reviewed
Mar 25, 2025
| ## Additional considerations | ||
|
|
||
| Consumers must ensure they take any additional considerations when customizing an accordion, using it in a way not described or recommended by PatternFly, or in various other specific use-cases not outlined elsewhere on this page. |
There was a problem hiding this comment.
Suggested change
| Consumers must ensure they take any additional considerations when customizing an accordion, using it in a way not described or recommended by PatternFly, or in various other specific use-cases not outlined elsewhere on this page. | |
| Consumers must ensure they take any additional considerations when customizing helper text, using it in a way not described or recommended by PatternFly, or in various other specific use-cases not outlined elsewhere on this page. |
Comment on lines
+102
to
+103
|
|
There was a problem hiding this comment.
Makes sense, though I'd also bring up localization as a consideration. It is something we use a lot in Cockpit so if there was a mix of two languages it would be strange
nicolethoen
approved these changes
Mar 25, 2025
|
@Venefilyn can you take a look at the latest update? Wasn't sure if that was what you had in mind or something else. |
Venefilyn
approved these changes
Apr 2, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to patternfly/patternfly-react#11704