feat(package): dual module support #11933
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11933.surge.sh A11y report: https://patternfly-react-pr-11933-a11y.surge.sh |
kmcfaul
commented
Jul 28, 2025
| @@ -19,7 +19,7 @@ import { draggable } from './utils/decorators/draggable'; | |||
| import { treeRow } from './utils'; | |||
| import { mergeProps } from './base/merge-props'; | |||
| import { IVisibility } from './utils/decorators/classNames'; | |||
| import { Tooltip } from '@patternfly/react-core/dist/esm/components/Tooltip/Tooltip'; | |||
There was a problem hiding this comment.
This is worth pointing out and thinking about - with the new export format, it appears that directory level imports and file level imports cannot exist simultaneously and be resolved successfully (component wildcard patterns end up interfering with each other).
Currently, only directory imports are supported so file imports like the above Tooltip won't work and would need to be updated. There are several of these type of imports reported in our analytics. Still investigating if that can be updated to support both.
kmcfaul
commented
Jul 28, 2025
| import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon'; | ||
| import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; | ||
| import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; | ||
| import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; | ||
| import imgAvatar from '@patternfly/react-core/src/components/assets/avatarImg.svg'; | ||
| // import imgAvatar from '../components/assets/avatarImg.svg'; |
There was a problem hiding this comment.
Look at inlining this.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11686
Assisted-by: Cursor
First pass on dual module package.json.
react-icons,react-tokens, andreact-stylesare not currently included because of what we output to the dist & what our docs expects when consuming our repos. Need to investigate further to see if we can adjust without breaking.