Skip to content

Configure ada_description for Articulable Fork #52

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

jjaime2
Copy link
Contributor

@jjaime2 jjaime2 commented Dec 12, 2024

Description

This pull request adds a configuration to specify the end_effector_tool which dynamically modifies the URDF from ada.xacro. This will allow users to specify tools from none, fork, and articulable_fork that will manifest kinematically and visually. For developers using ADA before the articulable fork hardware is transitioned in, set the tool to fork.

Related PRs: #53, #54, personalrobotics/ada_feeding#211

Testing procedure

  • Run ros2 launch ada_description view_ada.launch.py end_effector_tool:=<tool> for each <tool> in none, fork, and articulable_fork
  • Verify that ADA in RViz2 populates as expected with none having no tool, fork having the rigid fork assembly, and articulable_fork having the articulable fork whose joints can be commanded with the slider window

Before opening a pull request

  • pre-commit run --all-files
  • Run your code through pylint. pylint --recursive=y --rcfile=.pylintrc .. All warnings but fixme must be addressed.

Before Merging

  • Squash & Merge

@jjaime2 jjaime2 changed the title Parameterize ada_description with end_effector_tool Configure ada_description with end_effector_tool Jan 13, 2025
@jjaime2 jjaime2 changed the title Configure ada_description with end_effector_tool Configure ada_description for Articulable Fork Jan 13, 2025
Copy link
Contributor

@amalnanavati amalnanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All my comments before are small clarifications/nits. Unless you have further questions for me, feel free to merge it in after looking through/addressing the comments.

@jjaime2 jjaime2 marked this pull request as draft April 1, 2025 02:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants