Added code to check for 0 divisor #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterrows
commented
Nov 1, 2024
| @@ -3,11 +3,19 @@ | |||
| public class Division { | |||
|
|
|||
| public static final long division(int a, int b) { | |||
| if(b == 0) { | |||
| long result = ((long) a) / ((long) b); | ||
| return result; | ||
| } | ||
|
|
||
| public static final long divisionUsingLoop(int a, int b) { | ||
| if(b == 0) { | ||
| throw new IllegalArgumentException("Divisor cannot be zero"); |
There was a problem hiding this comment.
throws illegal argument exception.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0 divisors cause problems in code. These changes add to the robustness of the program by checking all division functions for a 0 divisor and throwing an error if we found a 0 divisor.