Cache multiple Android action button pushes if app is not running (#1272

)

* Use unique pending intent request code to enable multiple simultaneous notifications with action buttons

* Append i to notId to ensure pending intent request code is unique when multiple notId's are sequential

* Use random number for Android action button pending intent request codes

* By nicoabie: Cache multiple Android action button presses if the app is in the background (resolved conflicts)

* import java.util.ArrayList

* Revert changes to index.spec.js

* Use a synchonized list for gCachedExtras

src/android/com/adobe/phonegap/push/PushPlugin.java

@@ -22,6 +22,8 @@
 import java.util.Collections;
 import java.util.HashSet;
 import java.util.Iterator;
+import java.util.ArrayList;
+import java.util.List;
 
 import me.leolin.shortcutbadger.ShortcutBadger;
 
@@ -31,7 +33,7 @@ public class PushPlugin extends CordovaPlugin implements PushConstants {
 
     private static CallbackContext pushContext;
     private static CordovaWebView gWebView;
-    private static Bundle gCachedExtras = null;
+    private static List<Bundle> gCachedExtras = Collections.synchronizedList(new ArrayList<Bundle>());
     private static boolean gForeground = false;
 
     /**
@@ -133,10 +135,15 @@ else if (!savedSenderID.equals(senderID)) {
 
                     }
 
-                    if (gCachedExtras != null) {
+                    if (!gCachedExtras.isEmpty()) {
                         Log.v(LOG_TAG, "sending cached extras");
-                        sendExtras(gCachedExtras);
-                        gCachedExtras = null;
+                        synchronized(gCachedExtras) {
+                            Iterator<Bundle> gCachedExtrasIterator = gCachedExtras.iterator();
+                            while (gCachedExtrasIterator.hasNext()) {
+                                sendExtras(gCachedExtrasIterator.next());
+                            }
+                        }
+                        gCachedExtras.clear();
                     }
                 }
             });
@@ -169,8 +176,8 @@ public void run() {
                     } catch (IOException e) {
                         Log.e(LOG_TAG, "execute: Got JSON Exception " + e.getMessage());
                         callbackContext.error(e.getMessage());
+                    }
                 }
-            }
             });
         } else if (FINISH.equals(action)) {
             callbackContext.success();
@@ -279,7 +286,7 @@ public static void sendExtras(Bundle extras) {
                 sendEvent(convertBundleToJson(extras));
             } else {
                 Log.v(LOG_TAG, "sendExtras: caching extras to send at a later time.");
-                gCachedExtras = extras;
+                gCachedExtras.add(extras);
             }
         }
     }