New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

PHP 8.4 compat #145

Merged

sabas merged 3 commits into php-edifact:master from swiffer:php84-compat

Nov 25, 2024

Contributor

swiffer commented Nov 23, 2024

implicit nullable is deprecated -> https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

swiffer added 3 commits

November 23, 2024 09:32


          implicit nullable is deprecated

19d093f


          test with 8.3 (preinstalled in 24.04), as using phpunit 11

7f4712b


          keep type as is

0239aa3

Collaborator

sabas commented Nov 25, 2024

@swiffer can I merge?

Contributor Author

swiffer commented Nov 25, 2024

yes, i would say so. ci pipeline fixed and known deprecations handled.

sabas merged commit 385dd28 into php-edifact:master

1 check passed

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet