-
Notifications
You must be signed in to change notification settings - Fork 26
3.0 changelog #116
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
3.0 changelog #116
Conversation
Formatting conventions are now provided for compound types (those that include union or intersection type declarations). | ||
|
||
* The `|` and `&` symbols and parentheses MUST NOT have leading or trailing spaces. | ||
* If a type declaration is long enough to split to multiple lines, each ANDed block must be on one line, and each ORed block on its own line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* If a type declaration is long enough to split to multiple lines, each ANDed block must be on one line, and each ORed block on its own line. | |
* If a type declaration is long enough to split to multiple lines, each block must be on one line, and each block on its own line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is clear for what it implies. There's 2 different kinds of blocks, so it's not clear what this version is saying.
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, nice work 👍🏼
The links point to the live site, like the 2.0 changelog does, so not all of them will work yet. They should once it's tagged and published, though.