Skip to content

feat: remove ergebnis/composer-normalize #166

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

Chris53897
Copy link
Contributor

I want to test CI if is needed "ergebnis/composer-normalize" while it runs via docker gh actions

@dbu
Copy link
Contributor

dbu commented Oct 14, 2024

it seems to work. but we have some dev dependencies in composer.json require-dev so that people can run them locally, same with phpspec.

is there an issue with having normalize in the require-dev section?

@Chris53897
Copy link
Contributor Author

Only deprecations in the testruns for PHP 8.4.
Example: https://github.com/php-http/message/actions/runs/11143029675/job/30967217820

I have created a PR.
localheinz/diff#72

But i thought maybe it is not needed anymore, as it runs via docker gh actions.

@dbu
Copy link
Contributor

dbu commented Feb 15, 2025

@Chris53897 the fix to localheinz/diff has been merged and tagged. did that solve the deprecations, can we close this MR?

@Chris53897
Copy link
Contributor Author

Thanks for the reminder.
It looks good. https://github.com/php-http/message/actions/runs/13344353123/job/37272964327?pr=167
I will clsoe this PR.

@Chris53897 Chris53897 closed this Feb 15, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants